refactored for maintainability

internal/handlers/login.go

@@ -11,7 +11,9 @@ import (
 
 	"git.haelnorr.com/h/oslstats/internal/config"
 	"git.haelnorr.com/h/oslstats/internal/discord"
+	"git.haelnorr.com/h/oslstats/internal/notify"
 	"git.haelnorr.com/h/oslstats/internal/store"
+	"git.haelnorr.com/h/oslstats/internal/throw"
 	"git.haelnorr.com/h/oslstats/pkg/oauth"
 )
 
@@ -31,7 +33,7 @@ func Login(
 
 			if r.Method == "POST" {
 				if err != nil {
-					notifyServiceUnavailable(s, r, "Login currently unavailable", err)
+					notify.ServiceUnavailable(s, w, r, "Login currently unavailable", err)
 					w.WriteHeader(http.StatusOK)
 					return
 				}
@@ -40,46 +42,29 @@ func Login(
 			}
 
 			if err != nil {
-				throwServiceUnavailable(s, w, r, "Login currently unavailable", err)
+				throw.ServiceUnavailable(s, w, r, "Login currently unavailable", err)
 				return
 			}
 			cookies.SetPageFrom(w, r, cfg.HWSAuth.TrustedHost)
 			attempts, exceeded, track := st.TrackRedirect(r, "/login", 5)
 
 			if exceeded {
-				err := errors.Errorf(
-					"login redirect loop detected after %d attempts | ip=%s ua=%s path=%s first_seen=%s",
-					attempts,
-					track.IP,
-					track.UserAgent,
-					track.Path,
-					track.FirstSeen.Format("2006-01-02T15:04:05Z07:00"),
-				)
-
+				err = track.Error(attempts)
 				st.ClearRedirectTrack(r, "/login")
-
-				throwError(
-					s,
-					w,
-					r,
-					http.StatusBadRequest,
-					"Login failed: Too many redirect attempts. Please clear your browser cookies and try again.",
-					err,
-					"warn",
-				)
+				throw.BadRequest(s, w, r, "Too many redirects. Please clear your browser cookies and try again", err)
 				return
 			}
 
 			state, uak, err := oauth.GenerateState(cfg.OAuth, "login")
 			if err != nil {
-				throwInternalServiceError(s, w, r, "Failed to generate state token", err)
+				throw.InternalServiceError(s, w, r, "Failed to generate state token", err)
 				return
 			}
 			oauth.SetStateCookie(w, uak, cfg.HWSAuth.SSL)
 
 			link, err := discordAPI.GetOAuthLink(state)
 			if err != nil {
-				throwInternalServiceError(s, w, r, "An error occurred trying to generate the login link", err)
+				throw.InternalServiceError(s, w, r, "An error occurred trying to generate the login link", err)
 				return
 			}
 			st.ClearRedirectTrack(r, "/login")