added multiple method support for routes
This commit is contained in:
@@ -122,6 +122,111 @@ func Test_AddRoutes(t *testing.T) {
|
||||
})
|
||||
}
|
||||
|
||||
func Test_AddRoutes_MultipleMethods(t *testing.T) {
|
||||
var buf bytes.Buffer
|
||||
|
||||
t.Run("Single route with multiple methods", func(t *testing.T) {
|
||||
server := createTestServer(t, &buf)
|
||||
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
w.WriteHeader(http.StatusOK)
|
||||
w.Write([]byte(r.Method + " response"))
|
||||
})
|
||||
err := server.AddRoutes(hws.Route{
|
||||
Path: "/api/resource",
|
||||
Methods: []hws.Method{hws.MethodGET, hws.MethodPOST, hws.MethodPUT},
|
||||
Handler: handler,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
// Test GET request
|
||||
req := httptest.NewRequest("GET", "/api/resource", nil)
|
||||
rr := httptest.NewRecorder()
|
||||
server.Handler().ServeHTTP(rr, req)
|
||||
assert.Equal(t, http.StatusOK, rr.Code)
|
||||
assert.Equal(t, "GET response", rr.Body.String())
|
||||
|
||||
// Test POST request
|
||||
req = httptest.NewRequest("POST", "/api/resource", nil)
|
||||
rr = httptest.NewRecorder()
|
||||
server.Handler().ServeHTTP(rr, req)
|
||||
assert.Equal(t, http.StatusOK, rr.Code)
|
||||
assert.Equal(t, "POST response", rr.Body.String())
|
||||
|
||||
// Test PUT request
|
||||
req = httptest.NewRequest("PUT", "/api/resource", nil)
|
||||
rr = httptest.NewRecorder()
|
||||
server.Handler().ServeHTTP(rr, req)
|
||||
assert.Equal(t, http.StatusOK, rr.Code)
|
||||
assert.Equal(t, "PUT response", rr.Body.String())
|
||||
})
|
||||
|
||||
t.Run("Methods field takes precedence over Method field", func(t *testing.T) {
|
||||
server := createTestServer(t, &buf)
|
||||
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
w.WriteHeader(http.StatusOK)
|
||||
})
|
||||
err := server.AddRoutes(hws.Route{
|
||||
Path: "/test",
|
||||
Method: hws.MethodGET, // This should be ignored
|
||||
Methods: []hws.Method{hws.MethodPOST, hws.MethodPUT},
|
||||
Handler: handler,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
// GET should not work (Method field ignored)
|
||||
req := httptest.NewRequest("GET", "/test", nil)
|
||||
rr := httptest.NewRecorder()
|
||||
server.Handler().ServeHTTP(rr, req)
|
||||
assert.Equal(t, http.StatusMethodNotAllowed, rr.Code)
|
||||
|
||||
// POST should work (from Methods field)
|
||||
req = httptest.NewRequest("POST", "/test", nil)
|
||||
rr = httptest.NewRecorder()
|
||||
server.Handler().ServeHTTP(rr, req)
|
||||
assert.Equal(t, http.StatusOK, rr.Code)
|
||||
|
||||
// PUT should work (from Methods field)
|
||||
req = httptest.NewRequest("PUT", "/test", nil)
|
||||
rr = httptest.NewRecorder()
|
||||
server.Handler().ServeHTTP(rr, req)
|
||||
assert.Equal(t, http.StatusOK, rr.Code)
|
||||
})
|
||||
|
||||
t.Run("Invalid method in Methods slice", func(t *testing.T) {
|
||||
server := createTestServer(t, &buf)
|
||||
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
w.WriteHeader(http.StatusOK)
|
||||
})
|
||||
err := server.AddRoutes(hws.Route{
|
||||
Path: "/test",
|
||||
Methods: []hws.Method{hws.MethodGET, hws.Method("INVALID")},
|
||||
Handler: handler,
|
||||
})
|
||||
assert.Error(t, err)
|
||||
assert.Contains(t, err.Error(), "Invalid method")
|
||||
})
|
||||
|
||||
t.Run("Empty Methods slice falls back to Method field", func(t *testing.T) {
|
||||
server := createTestServer(t, &buf)
|
||||
handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
||||
w.WriteHeader(http.StatusOK)
|
||||
})
|
||||
err := server.AddRoutes(hws.Route{
|
||||
Path: "/test",
|
||||
Method: hws.MethodGET,
|
||||
Methods: []hws.Method{}, // Empty slice
|
||||
Handler: handler,
|
||||
})
|
||||
require.NoError(t, err)
|
||||
|
||||
// GET should work (from Method field)
|
||||
req := httptest.NewRequest("GET", "/test", nil)
|
||||
rr := httptest.NewRecorder()
|
||||
server.Handler().ServeHTTP(rr, req)
|
||||
assert.Equal(t, http.StatusOK, rr.Code)
|
||||
})
|
||||
}
|
||||
|
||||
func Test_Routes_EndToEnd(t *testing.T) {
|
||||
var buf bytes.Buffer
|
||||
server := createTestServer(t, &buf)
|
||||
@@ -146,7 +251,7 @@ func Test_Routes_EndToEnd(t *testing.T) {
|
||||
req := httptest.NewRequest("GET", "/get", nil)
|
||||
rr := httptest.NewRecorder()
|
||||
server.Handler().ServeHTTP(rr, req)
|
||||
|
||||
|
||||
assert.Equal(t, http.StatusOK, rr.Code)
|
||||
assert.Equal(t, "GET response", rr.Body.String())
|
||||
|
||||
@@ -154,7 +259,7 @@ func Test_Routes_EndToEnd(t *testing.T) {
|
||||
req = httptest.NewRequest("POST", "/post", nil)
|
||||
rr = httptest.NewRecorder()
|
||||
server.Handler().ServeHTTP(rr, req)
|
||||
|
||||
|
||||
assert.Equal(t, http.StatusCreated, rr.Code)
|
||||
assert.Equal(t, "POST response", rr.Body.String())
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user